Add rename branch functionality#8653
Merged
Chris2011 merged 1 commit intoapache:masterfrom Jul 21, 2025
Merged
Conversation
Contributor
matthiasblaesing
left a comment
There was a problem hiding this comment.
I see a small issue (see inline comment).
I reissued checks evaluation (locking and unlocking the conversion is the workaround for this) as the labels were set after the PR was opened.
ide/git/src/org/netbeans/modules/git/ui/repository/RepositoryBrowserPanel.java
Outdated
Show resolved
Hide resolved
Contributor
Author
Hey, yes this time I forgot to add the labels and everything else before creating the PR, sry. |
Contributor
Author
|
Thx, please recheck. |
ide/libs.git/src/org/netbeans/libs/git/jgit/commands/RenameBranchCommand.java
Outdated
Show resolved
Hide resolved
matthiasblaesing
requested changes
Jul 21, 2025
Contributor
matthiasblaesing
left a comment
There was a problem hiding this comment.
Sorry one last nitpick.
ide/libs.git/src/org/netbeans/libs/git/jgit/commands/RenameBranchCommand.java
Outdated
Show resolved
Hide resolved
matthiasblaesing
approved these changes
Jul 21, 2025
Contributor
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me.
9af3a54 to
467bbfe
Compare
Contributor
Author
|
@matthiasblaesing I just squashed the commits and will merge it soon. Thx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This functionality was missing long time and was also asked in a jira ticket: https://issues.apache.org/jira/browse/NETBEANS-3058
rename.branch.mp4
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)