fix: use named routes for redirects and form submission

[sammyskills]

Description

• Used named route for redirect in the src/Controllers/RegisterController.php file
• Used named route for form action in src/Views/email_action_show.php file.

Fixes #879

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• [] Unit testing, with >80% coverage
• [] User guide updated
• Conforms to style guide

[kenjis]

LGTM!

[kenjis]

@datamweb What is the docs?
I would like to merge this and release beta7 soon.

[sammyskills]

I was also wondering why @datamweb added the docs label 🤷‍♂️

[datamweb]

Guys,
It was not possible to use this method before, I know that there are people looking for this feature in the forum and even in the Github discussion, so it is better to add how to use this feature in the documents.

But I have a question, why do I face page 404 after using the following address?

$routes->group('{locale}', static function($routes) {
service('auth')->routes($routes);
});

localhost::8080/ja/login (is ok)

localhost::8080/login (404)
I would expect it to load with the default language set if no language is specified, not a 404 page. It is probably related to the framework?

Outside of this I feel it needs more investigation, about how to use filters and more.

In any case,
I don't have access to a PC right now, if you think there is ok, continue.

[sammyskills]

@datamweb, this is not a new feature. It is just a fix to make Shield routes less fragile by using named routes all through the codebase. Please read the issue #879 if you haven't read it already.

localhost::8080/login (404)
I would expect it to load with the default language set if no language is specified, not a 404 page. It is probably related to the framework?

What you are saying here (I think) is related to how you set up your locale to be detected. From the docs:

There are two methods supported to detect the correct locale during the request. The first is a “set and forget” method that will automatically perform content negotiation for you to determine the correct locale to use. The second method allows you to specify a segment in your routes that will be used to set the locale.

If you have set the locale using routes, then the system should be expecting localhost:8080/en/login as the default route assuming that your default locale is en.

Please try running the php spark routes command to see the available routes.

[kenjis]

@datamweb
{locale} in a route is just a wild card. It will be interpreted as the regex [^/]+.

$routes->group('{locale}', static function($routes) {
    service('auth')->routes($routes);
});

+--------+----------------------------------+--------------------+--------------------------------------------------------------------+----------------+---------------+
| Method | Route                            | Name               | Handler                                                            | Before Filters | After Filters |
+--------+----------------------------------+--------------------+--------------------------------------------------------------------+----------------+---------------+
| GET    | /                                | »                  | \App\Controllers\Home::index                                       | session        | toolbar       |
| GET    | {locale}/register                | register           | \CodeIgniter\Shield\Controllers\RegisterController::registerView   | session        | toolbar       |
| GET    | {locale}/login                   | login              | \CodeIgniter\Shield\Controllers\LoginController::loginView         | session        | toolbar       |
| GET    | {locale}/login/magic-link        | magic-link         | \CodeIgniter\Shield\Controllers\MagicLinkController::loginView     | session        | toolbar       |
| GET    | {locale}/login/verify-magic-link | verify-magic-link  | \CodeIgniter\Shield\Controllers\MagicLinkController::verify        | session        | toolbar       |
| GET    | {locale}/logout                  | logout             | \CodeIgniter\Shield\Controllers\LoginController::logoutAction      | session        | toolbar       |
| GET    | {locale}/auth/a/show             | auth-action-show   | \CodeIgniter\Shield\Controllers\ActionController::show             | session        | toolbar       |
| POST   | {locale}/register                | register           | \CodeIgniter\Shield\Controllers\RegisterController::registerAction | session        | toolbar       |
| POST   | {locale}/login                   | »                  | \CodeIgniter\Shield\Controllers\LoginController::loginAction       | session        | toolbar       |
| POST   | {locale}/login/magic-link        | »                  | \CodeIgniter\Shield\Controllers\MagicLinkController::loginAction   | session        | toolbar       |
| POST   | {locale}/auth/a/handle           | auth-action-handle | \CodeIgniter\Shield\Controllers\ActionController::handle           | session        | toolbar       |
| POST   | {locale}/auth/a/verify           | auth-action-verify | \CodeIgniter\Shield\Controllers\ActionController::verify           | session        | toolbar       |
+--------+----------------------------------+--------------------+--------------------------------------------------------------------+----------------+---------------+

[kenjis]

@datamweb I sent a PR for docs: #884

[datamweb]

@sammyskills and @kenjis thank you!