Replies: 1 comment
-
|
Great catch. You were right that this mixed two separate things, so I split them in 97474a9
So we keep migrations clean and avoid test/setup breakage (like |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
The CreateModels schema migration currently has a data migration mixed in:
Having mixed type migrations (data and schema) is usually a code smell. Puritanism aside, it led me to an real world problem: I'm moving from ruby-openai to ruby_llm, and my test suite is failing because test envs typically do db:schema:load, skipping the data migration. So I get
RubyLLM::ModelNotFoundError: Unknown model: gpt-4o-minierrors because the table is empty.Beta Was this translation helpful? Give feedback.
All reactions