Fix RuntimeError in REXML::Parsers::BaseParser for valid feeds

[vikiv480]

• Change #entity to not match against default entities

After this change, the following example will not raise a RuntimeError:

# rexml/refactor_entity_example.rb

$LOAD_PATH.unshift(File.expand_path("lib"))

require "rexml/parsers/baseparser"

valid_feed = "<p>#{'A' * 10_240}</p>"

base_parser = REXML::Parsers::BaseParser.new("")
base_parser.unnormalize(valid_feed) # => "<p>" + "A" * 10_240 + "</p>"

Default entities now gets substituted by this block instead

rexml/lib/rexml/parsers/baseparser.rb

Lines 560 to 563 in e14847c

	else
	er = DEFAULT_ENTITIES[entity_reference]
	rv.gsub!( er[0], er[2] ) if er
	end

Close #198

[kou]

Could you add a test for this case?

[kou]

@naitoh Could you review this?

[vikiv480]

Could you add a test for this case?

I've added some tests in 6555c27, let me know what you think.

[naitoh]

Could you review this?

before (This PR)

      def entity( reference, entities )
        value = nil
        value = entities[ reference ] if entities
        if value
          record_entity_expansion
          return unnormalize( value, entities )
        end

        nil
      end

• If entities == nil, the return value is nil because value is always nil.
• If value == nil, the return value is nil, so an early return is easier to understand.

after

      def entity( reference, entities )
        return unless entities

        value = entities[ reference ]
        return if value.nil?

        record_entity_expansion
        unnormalize( value, entities )
      end

Thanks.

[vikiv480]

@naitoh Thanks for the suggestion, I like the change 👍 60632a5

[naitoh]

Additional review.

[naitoh]

I have checked this PR.
I think this PR is good.
Thanks!

[kou]

Thanks.