Skip to content

fix(desktop): update ahead/behind on sidebar-hover cadence#1770

Merged
Kitenite merged 1 commit intosuperset-sh:mainfrom
Kitenite:kitenite/main-pull-state-slow
Feb 25, 2026
Merged

fix(desktop): update ahead/behind on sidebar-hover cadence#1770
Kitenite merged 1 commit intosuperset-sh:mainfrom
Kitenite:kitenite/main-pull-state-slow

Conversation

@Kitenite
Copy link
Collaborator

@Kitenite Kitenite commented Feb 25, 2026

Summary

  • align branch-workspace ahead/behind query stale time with sidebar git status timing (30s)
  • start ahead/behind interval refresh after workspace item hover, matching sidebar hover-driven status behavior
  • remove the separate 60s ahead/behind constant

Testing

  • bunx biome check apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/WorkspaceListItem.tsx apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/constants.ts

Summary by CodeRabbit

  • Refactor
    • Adjusted branch status data refresh timing for workspace display to use consistent GitHub status configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99a7b0d and d5f4f1f.

📒 Files selected for processing (2)
  • apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/WorkspaceListItem.tsx
  • apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/constants.ts
💤 Files with no reviewable changes (1)
  • apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/constants.ts

📝 Walkthrough

Walkthrough

The changes consolidate ahead/behind query timing configuration by replacing the dedicated AHEAD_BEHIND_STALE_TIME constant with the reusable GITHUB_STATUS_STALE_TIME constant. The unused AHEAD_BEHIND_STALE_TIME export is removed from constants, and the component is updated to reference the new timing constant with hover-based refetch triggering.

Changes

Cohort / File(s) Summary
Configuration Consolidation
apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/constants.ts
Removed unused AHEAD_BEHIND_STALE_TIME constant export.
Timing Reference Update
apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/WorkspaceListItem.tsx
Updated ahead/behind query to use GITHUB_STATUS_STALE_TIME instead of AHEAD_BEHIND_STALE_TIME; refetchInterval now conditionally set based on hover state.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit hops with glee,
Constants consolidated, clean and free,
One timing for status, sleek and neat,
The unused one removed—refactor's sweet! 🌟

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description covers key changes and testing, but is missing required template sections like Related Issues and Type of Change. Complete the description template by adding Related Issues and Type of Change sections to provide full context.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: updating the ahead/behind query to use sidebar-hover cadence instead of a separate 60s interval.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kitenite Kitenite merged commit 182ed72 into superset-sh:main Feb 25, 2026
6 checks passed
@Kitenite Kitenite deleted the kitenite/main-pull-state-slow branch February 25, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant