London | 26-ITP-Jan | Raihan Sharif | Sprint 3 | Alarm Clock#964
Open
RaihanSharif wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Raihan Sharif | Sprint 3 | Alarm Clock#964RaihanSharif wants to merge 1 commit intoCodeYourFuture:mainfrom
RaihanSharif wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
RaihanSharif
added
the
Needs Review
A-O-Emmanuel
added
Review in progress
A-O-Emmanuel
left a comment
A-O-Emmanuel
left a comment
There was a problem hiding this comment.
Your implementation works, good job!
A-O-Emmanuel
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Created alarm clock using setInterval as a clock tick.
Questions
I tried to use setInterval to poll Date.now() every 500ms, as I thought that would be more robust, but the test suit meant I couldn't do that. How strict are you about following the spec?