fix: tolerate zip exit code 18 in web server backup

[trex0r]

Addresses this issue: #3853

The zip command exits with code 18 ("completed with warnings, some files not readable"), which execAsync treats as a fatal error — even though

The fix is to wrap the zip execAsync call in a try/catch that tolerates exit code 18 specifically. All other non-zero exit codes still throw as before

Greptile Summary

Wrapped the zip command in a try/catch block to specifically tolerate exit code 18 (warnings about unreadable files like sockets/pipes), allowing backups to succeed despite non-critical warnings. All other errors continue to be thrown as expected. The fix correctly imports ExecError and uses proper instanceof checking with the exit code comparison.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• Score reflects a focused, well-implemented fix that addresses the specific issue without introducing new risks. The error handling is correct and preserves all other error conditions.
• No files require special attention

_{Last reviewed commit: 245ad90}

_{(2/5) Greptile learns from your feedback when you react with thumbs up/down!}

[dosubot]

Related Documentation

Checked 7 published document(s) in 1 knowledge base(s). No updates required.

^{How did I do? Any feedback?}  

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Consider logging when exit code 18 occurs for better observability

Suggested change

	try {
	await execAsync(
	`cd ${tempDir} && zip -r ${backupFileName} *.sql filesystem/ > /dev/null 2>&1`,
	);
	} catch (error) {
	// zip exit code 18 = "completed with warnings, some files not readable"
	// This happens when sockets/pipes exist under /etc/dokploy/ — the archive is still valid
	if (!(error instanceof ExecError && error.exitCode === 18)) {
	throw error;
	}
	}
	try {
	await execAsync(
	`cd ${tempDir} && zip -r ${backupFileName} *.sql filesystem/ > /dev/null 2>&1`,
	);
	} catch (error) {
	// zip exit code 18 = "completed with warnings, some files not readable"
	// This happens when sockets/pipes exist under /etc/dokploy/ — the archive is still valid
	if (!(error instanceof ExecError && error.exitCode === 18)) {
	throw error;
	}
	writeStream.write("Backup completed with warnings (some files not readable)\n");
	}

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}