fix(tray): svg's did not load#1397
Open
pancakedevourer wants to merge 9 commits intoJakeStanger:masterfrom
Open
fix(tray): svg's did not load#1397pancakedevourer wants to merge 9 commits intoJakeStanger:masterfrom
pancakedevourer wants to merge 9 commits intoJakeStanger:masterfrom
Conversation
Owner
|
Thanks for this. I think this somewhat duplicates the logic in Are you able to have a look and see if there's any opportunity to clear that up a bit please? Ideally we'd have one path through. |
JakeStanger
added
Z:Changes Requested
github-actions
bot
added
Z:Review Required
Author
|
Sorry for the holdup, cleaned it up. Logic is in icon.rs now |
Owner
|
Thanks. Can you have a look at the failing build please? |
Author
|
Whoops, fixed it |
JakeStanger
requested changes
Feb 28, 2026
| use system_tray::item::IconPixmap; | ||
| use tokio::sync::mpsc; | ||
| use tracing::{debug, error, trace, warn}; | ||
|
|
Owner
There was a problem hiding this comment.
Please re-add the whitespace between lines that's been removed throughout this file
src/modules/tray/mod.rs
Outdated
Comment on lines
+409
to
+413
| // Register a fresh picture and ensure a label widget exists, | ||
| // then load the image asynchronously. | ||
| let picture = Picture::builder() | ||
| .content_fit(ContentFit::ScaleDown) | ||
| .build(); |
Owner
There was a problem hiding this comment.
Why are we creating a new picture instead of using the existing one?
JakeStanger
added
Z:Changes Requested
github-actions
bot
added
Z:Review Required
Author
|
Here you go. Kakoune removed most of the whitespace when I saved the file, for some unbeknownst reason |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SVG icons couldn't load in the tray before, and showed a disconnected icon.
fixes #1221