build: Bump all dependencies across every ecosystems#2690
build: Bump all dependencies across every ecosystems#2690
Conversation
I can't believe this happened
Axelen123
left a comment
There was a problem hiding this comment.
Have you tested to ensure the app isn't broken by the dependency bumps?
Not that I know of, patching is fine, settings is fine, navigation is fine. |
|
I'll put this into draft, awaiting #2663 merge. |
| pull_request: | ||
| branches: | ||
| - dev | ||
| - compose-dev |
There was a problem hiding this comment.
Now that a release is incoming, yes.
| - compose-dev |
| compileSdk = 35 | ||
| buildToolsVersion = "35.0.1" | ||
| compileSdk = 36 | ||
| buildToolsVersion = "36.0.0" |
There was a problem hiding this comment.
we're bumping the target and compile sdk to 36, so it would also be appropriate to update the build tools to 36 also. (even though using 35.0.0 or 36.1.0 or 34.0.0 is fine really but it doesn't make sense.)
| } | ||
|
|
||
| buildTypes { | ||
| configureEach { |
There was a problem hiding this comment.
Leftovers, forgot to remove.
| fun LocalDateTime.relativeTime(context: Context): String { | ||
| try { | ||
| val now = Clock.System.now() | ||
| val now = kotlin.time.Clock.System.now() |
| pull_request: | ||
| branches: | ||
| - dev | ||
| - compose-dev |
There was a problem hiding this comment.
Now that a release is incoming, yes.
| - compose-dev |
| compileSdk = 35 | ||
| buildToolsVersion = "35.0.1" | ||
| compileSdk = 36 | ||
| buildToolsVersion = "36.0.0" |
There was a problem hiding this comment.
we're bumping the target and compile sdk to 36, so it would also be appropriate to update the build tools to 36 also. (even though using 35.0.0 or 36.1.0 or 34.0.0 is fine really but it doesn't make sense.)
| } | ||
|
|
||
| buildTypes { | ||
| configureEach { |
There was a problem hiding this comment.
Leftovers, forgot to remove.
|
This PR is easier redone than dealing with the merge conflicts, please git reset this branch and re-apply the changes and have this merged quickly before it's obselete again |
Bump dependencies on every ecosystems, optimise the heck out of Gradle from 445s to 184s (170s execution) on my pc on gradle assembleDebug (clean build), and make CI work again
I hate android studio
Make projects type safe, migrate major breaking based on their documentation except for Placeholder that i didn't bother