heap-based buffer overflow

[ChenBeiYi]

This is a system error prompt popped up by the "PicView.exe" program in the Windows system. The core issue is a "heap-based buffer overflow", which is a program security error

systeam ：win11 23h2

[ChenBeiYi]

"Hi there, clever developer! Thanks for creating this image viewer software. Could you take a look at this error message, please?"

Event Viewer Code

Application: PicView.exe
CoreCLR Version: 10.0.1
Description: The process was terminated due to an unhandled exception.
Exception Info: System.NullReferenceException: Object reference not set to an instance of an object.
at PicView.Avalonia.UI.ScreenHelper.UpdateScreenSize(Window) + 0x62
at PicView.Avalonia.StartUp.StartUpHelper.HandlePostWindowUpdates(MainViewModel, Boolean, IClassicDesktopStyleApplicationLifetime, Window) + 0x10d
at PicView.Avalonia.Win32.App.OnFrameworkInitializationCompleted() + 0x3e8
at Avalonia.ClassicDesktopStyleApplicationLifetimeExtensions.StartWithClassicDesktopLifetime(AppBuilder, String[], ShutdownMode) + 0x62
at PicView.Avalonia.Win32.Program.Main(String[] args) + 0x1e

xml

-
-

1026
0
2
0
0
0x80000000000000

194


Application
Beiyi


-
Application: PicView.exe CoreCLR Version: 10.0.1 Description: The process was terminated due to an unhandled exception. Exception Info: System.NullReferenceException: Object reference not set to an instance of an object. at PicView.Avalonia.UI.ScreenHelper.UpdateScreenSize(Window) + 0x62 at PicView.Avalonia.StartUp.StartUpHelper.HandlePostWindowUpdates(MainViewModel, Boolean, IClassicDesktopStyleApplicationLifetime, Window) + 0x10d at PicView.Avalonia.Win32.App.OnFrameworkInitializationCompleted() + 0x3e8 at Avalonia.ClassicDesktopStyleApplicationLifetimeExtensions.StartWithClassicDesktopLifetime(AppBuilder, String[], ShutdownMode) + 0x62 at PicView.Avalonia.Win32.Program.Main(String[] args) + 0x1e

[ChenBeiYi]

This issue persists in both the latest versions 4.1.1 and 4.1.0

[Ruben2776]

I can't reproduce your issue, however I think there might be a problem with AvaloniaUI recognizing your screen (which is used to calculate window size versus image size).

I have created an updated version, that uses a placeholder screen at 1920 x 1080, when it doesn't return the monitor screen's actual values.

Download it, at the bottom of this page (while being logged in to GitHub), and try to see if it solves your issue:
https://github.com/Ruben2776/PicView/actions/runs/20989804369?target=https://github.com

[ChenBeiYi]

I'll give it a try.Thank you very much for your reply.

[ChenBeiYi]

I just tested the new version—it's running perfectly so far, no problems whatsoever! I'll let you know if any issues arise later. Thank you so much for your hard work on this project!