Skip to content

✨ Added more card types to the welcome email editor, like images#26645

Draft
EvanHahn wants to merge 2 commits intomainfrom
ny-1104-welcomeemaileditor-ga
Draft

✨ Added more card types to the welcome email editor, like images#26645
EvanHahn wants to merge 2 commits intomainfrom
ny-1104-welcomeemaileditor-ga

Conversation

@EvanHahn
Copy link
Contributor

@EvanHahn EvanHahn commented Mar 2, 2026

closes https://linear.app/ghost/issue/NY-1104

Moved the welcomeEmailEditor feature flag to GA.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 2, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ny-1104-welcomeemaileditor-ga

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ErisDS
Copy link
Member

ErisDS commented Mar 2, 2026

🤖 Velo CI Failure Analysis

Classification: 🟠 SOFT FAIL

  • Workflow: CI
  • Failed Step: E2E tests
  • Run: View failed run
    What failed: Test snapshot mismatch for Stripe settings edit
    Why: The root cause is a test assertion failure where the response headers from the Stripe settings edit endpoint do not match the expected snapshot. This is a code issue, as the test is validating the application's behavior.
    Action:
    The developer should investigate the Stripe settings edit functionality and update the test snapshot to match the expected response headers.

ref https://linear.app/ghost/issue/NY-1104/move-welcomeemaileditor-feature-flag-to-ga-available-for-all
The welcomeEmailEditor GA change alters the settings payload size, so the header snapshot needed refreshing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants