feat(egress): add Prometheus metrics, METRICS.md, and metrics fetch in smoke tests#247
feat(egress): add Prometheus metrics, METRICS.md, and metrics fetch in smoke tests#247Pangjiping wants to merge 1 commit intoalibaba:mainfrom
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93ee89a8f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| NftDohDotPacketsDroppedTotal = promauto.NewCounterVec( | ||
| prometheus.CounterOpts{ | ||
| Namespace: namespace, | ||
| Subsystem: subsystem, | ||
| Name: "nft_doh_dot_packets_dropped_total", |
There was a problem hiding this comment.
Wire DoH/DoT drop counter to real drop events
This metric is declared but never incremented in the new instrumentation paths (there is no NftDohDotPacketsDroppedTotal.WithLabelValues(...).Inc() call in nft.go, policy_server.go, or other egress code), so in dns+nft mode /metrics will never surface actual DoH/DoT drops. Any dashboard or alert relying on opensandbox_egress_nft_doh_dot_packets_dropped_total will silently under-report enforcement behavior.
Useful? React with 👍 / 👎.
Summary
Testing
Breaking Changes
Checklist