GH-49422: [CI][Integration][Ruby] Add the Ruby implementation#49423
Open
kou wants to merge 1 commit intoapache:mainfrom
Open
GH-49422: [CI][Integration][Ruby] Add the Ruby implementation#49423kou wants to merge 1 commit intoapache:mainfrom
kou wants to merge 1 commit intoapache:mainfrom
Conversation
|
|
ce220a9 to
b5b1a33
Compare
Member
Author
|
This is ready. |
b5b1a33 to
67857c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
There are some missing features in the Ruby implementaion for now but we can pass them by skipping some tests in our integration tests.
What changes are included in this PR?
Archery:
--with-rubytoarchery integrationarchery.integration.tester_ruby.RubyTesterno_map_field_names_validatequirk for [C++] Map type ignores key/item/value field names #49415ARCHERY_INTEGRATION_WITH_CPP=1instead ofARROW_INTEGRATION_CPP=ONlike other implementations such asARCHERY_INTEGRATION_WITH_GOno_map_field_names_validatequirk for .NET/Go/JS and old C++ implementationsRuby:
red-arrow-format-integration-testas the test driver.gembecause this is only for developmentruby/red-arrow-format/lib/arrow-format/integration/as helpers of the test driver.gembecause this is only for developmentArrowFormat::Array#empty?ArrowFormat::RecordBatch#empty?ArrowFormat::NullArray#n_nullsArrowFormat::*Array#to_a: Add support for empty caseBigDecimalconversionArrowFormat::Bitmap#each: Fix a bug that one bit is ignoredArrowFormat::DictionaryTypefromArrowFormat::FieldArrowFormat::StreamingReader: Add support for reading schema without calling#eachArrowFormat::MapType: Add support for keys sortedAre these changes tested?
Yes.
Are there any user-facing changes?
Yes.