[FLINK-39181 ][ci] Reduce Verbose DEBUG Logging in CI#27722
Open
MartijnVisser wants to merge 2 commits intoapache:masterfrom
Open
[FLINK-39181 ][ci] Reduce Verbose DEBUG Logging in CI#27722MartijnVisser wants to merge 2 commits intoapache:masterfrom
MartijnVisser wants to merge 2 commits intoapache:masterfrom
Conversation
…in tests Reduce verbose DEBUG log output in CI test runs by changing the ZooKeeper FinalRequestProcessor logger from DEBUG to INFO and removing DEBUG-level logging for leader election/retrieval packages.
Move the shade plugin DEBUG log flag from global Maven options to the specific compile.sh deploy invocation where it is needed by the ShadeParser and NoticeFileChecker. This prevents verbose bytecode rewriting messages from flooding test run console output.
Collaborator
davidradl
reviewed
Mar 2, 2026
| logger.shaded_zookeeper.additivity = false | ||
| logger.shaded_zookeeper.appenderRef.zk.ref = ZooKeeperClientAppender | ||
|
|
||
| logger.leaderretrieval.name = org.apache.flink.runtime.leaderretrieval |
Contributor
There was a problem hiding this comment.
I looked at the code in this package - the log.debugs in ZooKeeperLeaderRetrievalDriver are not enclosed with if (LOG.isDebugEnabled()) { . I suggest adding if (LOG.isDebugEnabled()) { around the 3 log.debugs. The one I am most concerned about is
snuyanzin
reviewed
Mar 2, 2026
| # run with -T1 because our maven output parsers don't support multi-threaded builds | ||
| $MVN clean deploy -DaltDeploymentRepository=validation_repository::default::file:$MVN_VALIDATION_DIR -Dflink.convergence.phase=install -Pcheck-convergence \ | ||
| -Dmaven.javadoc.skip=true -U -DskipTests "${@}" -T1 | tee $MVN_CLEAN_COMPILE_OUT | ||
| -Dmaven.javadoc.skip=true -U -DskipTests -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.shade=DEBUG "${@}" -T1 | tee $MVN_CLEAN_COMPILE_OUT |
Contributor
There was a problem hiding this comment.
can we check that LicenseChecker still works after that?
Contributor
Author
There was a problem hiding this comment.
Definitely, but I needed a CI run first to see it, then deliberately mess it up somewhere to trigger it, and then fix it afterwards again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
CI test runs produce excessive DEBUG log output in the GitHub Actions console. The primary source is Maven Shade Plugin bytecode rewriting messages (
Keeping original class bytecode,Rewrote class bytecode) that appear during test runs. The shade DEBUG flag (-Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.shade=DEBUG) was added globally in FLINK-38711 for the license checker, but it only needs to be active during the compile/deploy step. Additionally,log4j.propertiesenables DEBUG for ZooKeeperFinalRequestProcessorand leader election/retrieval packages, adding unnecessary noise to test log files.Brief change log
compile.shdeploy invocation whereShadeParser/NoticeFileCheckerneeds itFinalRequestProcessorlogger from DEBUG to INFOorg.apache.flink.runtime.leaderretrievalandorg.apache.flink.runtime.leaderelectionVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Full validation requires a CI run: the packaging/licensing job should pass (ShadeParser still sees DEBUG output from
compile.sh), and test job console output should no longer contain shade plugin bytecode rewriting noise.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation