Skip to content

Github link added to the techyons#6039

Open
saranyakathiravan-techyonsadharagarwal wants to merge 3 commits intoavelino:mainfrom
saranyakathiravan-techyonsadharagarwal:main
Open

Github link added to the techyons#6039
saranyakathiravan-techyonsadharagarwal wants to merge 3 commits intoavelino:mainfrom
saranyakathiravan-techyonsadharagarwal:main

Conversation

@saranyakathiravan-techyonsadharagarwal

We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.

Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link.
  • The repo documentation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • Continuous integration is used to attempt to catch issues prior to releasing this package to end-users.

Please provide some links to your package to ease the review

  • forge link (github.com, gitlab.com, etc):
  • pkg.go.dev:
  • goreportcard.com:
  • coverage service link (codecov, coveralls, etc.):

Pull Request content

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.

Category quality

Note that new categories can be added only when there are 3 packages or more.

Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.

Please delete one of the following lines:

  • The packages around my addition still meet the Quality Standards.
  • I removed the following packages around my addition: (please give a short reason for each removal)

Thanks for your PR, you're awesome! 😎

@github-actions
Copy link

Automated Quality Checks (from CONTRIBUTING minimum standards)

  • Repo link: missing
  • pkg.go.dev: missing
  • goreportcard: missing
  • coverage: missing

These checks are a best-effort automation and do not replace human review.

- [vFlow](https://github.com/VerizonDigital/vflow)?target=https://github.com - High-performance, scalable and reliable IPFIX, sFlow and Netflow collector.
- [Wave Terminal](https://waveterm.dev) - Wave is an open-source, AI-native terminal built for seamless developer workflows with inline rendering, a modern UI, and persistent sessions.
- [wellington](https://github.com/wellington/wellington)?target=https://github.com - Sass project management tool, extends the language with sprite functions (like Compass).
- [techyons](https://github.com/saranyakathiravan-techyonsadharagarwal/techyons-techyons-go)?target=https://github.com — Unified workspace for projects, meetings, docs, and AI insights.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The new "techyons" entry in README.md is not in alphabetical order and uses an em dash (—) instead of a hyphen (-), which will cause CI tests to fail.
Severity: CRITICAL

Suggested Fix

Move the "techyons" entry before the "wellington" entry to maintain alphabetical order. Additionally, replace the em dash (—) with a hyphen (-) between the link and the description to match the project's required format.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: README.md#L3473

Potential issue: The new "techyons" entry in `README.md` violates two project validation
rules, which will cause CI tests to fail. First, it is not in the correct alphabetical
position; it is placed after "wellington" when it should be before. This will be caught
by the `TestAlpha` test. Second, it uses an em dash (—) as a separator instead of the
required hyphen (-). This will cause the `TestSeparator` test to fail because its regex,
`reLinkWithDescription`, specifically expects a hyphen. Both issues need to be corrected
for the CI checks to pass.

Did we get this right? 👍 / 👎 to inform future reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants