Github link added to the techyons#6039
Open
saranyakathiravan-techyonsadharagarwal wants to merge 3 commits intoavelino:mainfrom
Open
Github link added to the techyons#6039saranyakathiravan-techyonsadharagarwal wants to merge 3 commits intoavelino:mainfrom
saranyakathiravan-techyonsadharagarwal wants to merge 3 commits intoavelino:mainfrom
Conversation
|
Automated Quality Checks (from CONTRIBUTING minimum standards)
These checks are a best-effort automation and do not replace human review. |
| - [vFlow](https://github.com/VerizonDigital/vflow)?target=https://github.com - High-performance, scalable and reliable IPFIX, sFlow and Netflow collector. | ||
| - [Wave Terminal](https://waveterm.dev) - Wave is an open-source, AI-native terminal built for seamless developer workflows with inline rendering, a modern UI, and persistent sessions. | ||
| - [wellington](https://github.com/wellington/wellington)?target=https://github.com - Sass project management tool, extends the language with sprite functions (like Compass). | ||
| - [techyons](https://github.com/saranyakathiravan-techyonsadharagarwal/techyons-techyons-go)?target=https://github.com — Unified workspace for projects, meetings, docs, and AI insights. |
There was a problem hiding this comment.
Bug: The new "techyons" entry in README.md is not in alphabetical order and uses an em dash (—) instead of a hyphen (-), which will cause CI tests to fail.
Severity: CRITICAL
Suggested Fix
Move the "techyons" entry before the "wellington" entry to maintain alphabetical order. Additionally, replace the em dash (—) with a hyphen (-) between the link and the description to match the project's required format.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: README.md#L3473
Potential issue: The new "techyons" entry in `README.md` violates two project validation
rules, which will cause CI tests to fail. First, it is not in the correct alphabetical
position; it is placed after "wellington" when it should be before. This will be caught
by the `TestAlpha` test. Second, it uses an em dash (—) as a separator instead of the
required hyphen (-). This will cause the `TestSeparator` test to fail because its regex,
`reLinkWithDescription`, specifically expects a hyphen. Both issues need to be corrected
for the CI checks to pass.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.
Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.
Please provide some links to your package to ease the review
Pull Request content
Category quality
Note that new categories can be added only when there are 3 packages or more.
Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.
Please delete one of the following lines:
Thanks for your PR, you're awesome! 😎