fix: respect destination_uuid in API for applications and services#8653
Open
sharkcreep87 wants to merge 1 commit intocoollabsio:nextfrom
Open
fix: respect destination_uuid in API for applications and services#8653sharkcreep87 wants to merge 1 commit intocoollabsio:nextfrom
sharkcreep87 wants to merge 1 commit intocoollabsio:nextfrom
Conversation
…ervices The API was ignoring the destination_uuid parameter when creating applications or services, always deploying to the first destination on the server. This applies the same fix from PR coollabsio#7002 (databases) to ApplicationsController and ServicesController. Fixes coollabsio#8645
cbffd56 to
8c19dde
Compare
sharkcreep87
commented
Feb 27, 2026
Author
sharkcreep87
left a comment
There was a problem hiding this comment.
Self-review — this follows the exact same pattern already merged in PR #7002 for DatabasesController. All three locations are consistent:
ApplicationsController::create_application()✅ServicesController::create_service()✅ServicesController::update_by_uuid()✅
Each correctly filters by destination_uuid when provided, with proper 422 validation if the UUID doesn't belong to the server. No regressions for single-destination servers (falls through to ->first()).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
destination_uuidparameter when creating applications or services, always deploying to the first destination on the serverApplicationsControllerandServicesControllerdestination_uuiddoesn't belong to the specified serverFixes #8645
Changes
ApplicationsController.phpcreate_application()destination_uuidwhen providedServicesController.phpcreate_service()destination_uuidwhen providedServicesController.phpupdate_by_uuid()destination_uuidwhen providedTest plan
destination_uuid→ verify a 422 validation error is returneddestination_uuid) → verify it still works as before (uses the only destination)