Open
Conversation
gregorydemay
reviewed
Mar 4, 2026
Comment on lines
+30
to
+32
| assert!(Regex::new(SOLANA_PUBKEY_REGEX) | ||
| .unwrap() | ||
| .is_match(&result.leader)); |
Contributor
There was a problem hiding this comment.
understanding question: why do we need to verify that this is syntactically correct Solana public key? This is after all a canhttp example (not specific to Solana)
Contributor
Author
There was a problem hiding this comment.
This is not super strictly needed, I just wanted to add a sanity check that the results somewhat makes sense. I could also just have assert!(result.leader().len() > 0) or so... WDYT?
Contributor
Author
There was a problem hiding this comment.
Actually, I just relaxed the assertion to assert!(result.leader().len() > 0) since you are right, the regex was overkill here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a faulty test assertion which led to the
should_make_batch_json_rpc_requestbeing flaky. The test previously asserted that the result of the Solana JSON-RPCgetSlotLeadercall should be a 44-character string. However, this is not always the case (see the Solana docs here), so the assertion is relaxed to simply check the string is not empty.