Skip to content

chore: deprecate symmetryutilities method#171

Merged
sbillinge merged 2 commits intodiffpy:v3.4.0from
stevenhua0320:deprecate-symmetryutilities-7
Mar 3, 2026
Merged

chore: deprecate symmetryutilities method#171
sbillinge merged 2 commits intodiffpy:v3.4.0from
stevenhua0320:deprecate-symmetryutilities-7

Conversation

@stevenhua0320
Copy link
Contributor

@sbillinge ready to review

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.12%. Comparing base (820a3d6) to head (f489b30).
⚠️ Report is 4 commits behind head on v3.4.0.

Additional details and impacted files
@@            Coverage Diff             @@
##           v3.4.0     #171      +/-   ##
==========================================
+ Coverage   99.10%   99.12%   +0.02%     
==========================================
  Files          13       13              
  Lines        2226     2291      +65     
==========================================
+ Hits         2206     2271      +65     
  Misses         20       20              
Files with missing lines Coverage Δ
tests/test_symmetryutilities.py 99.83% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this. One tiny typo


* Added ``position_formulas`` method in ``SymmetryConstraints`` class
* Added ``position_formulas_pruned`` method in ``SymmetryConstraints`` class
* Added ``u_formula_pruned`` method in ``SymmetryConstraints`` class
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we lose an "s" here?

@sbillinge sbillinge merged commit 64aa1c7 into diffpy:v3.4.0 Mar 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants