feat(fcm): Add bandwidthConstrainedOk and restrictedSatelliteOk#2994
Open
lahirumaramba wants to merge 2 commits intomainfrom
Open
feat(fcm): Add bandwidthConstrainedOk and restrictedSatelliteOk#2994lahirumaramba wants to merge 2 commits intomainfrom
lahirumaramba wants to merge 2 commits intomainfrom
Conversation
… to AndroidConfig Adds two new optional boolean properties, `bandwidthConstrainedOk` and `restrictedSatelliteOk`, to the `AndroidConfig` type in the messaging API. This change includes: - Updating the `AndroidConfig` interface in `src/messaging/messaging-api.ts`. - Adding the corresponding property mappings in `src/messaging/messaging-internal.ts`. - Updating unit tests in `test/unit/messaging/messaging.spec.ts` to cover the new properties.
… to AndroidConfig Adds two new optional boolean properties, `bandwidthConstrainedOk` and `restrictedSatelliteOk`, to the `AndroidConfig` type in the messaging API. This change includes: - Updating the `AndroidConfig` interface in `src/messaging/messaging-api.ts`. - Adding the corresponding property mappings in `src/messaging/messaging-internal.ts`. - Updating unit tests in `test/unit/messaging/messaging.spec.ts` to cover the new properties. - Updating the public API documentation.
jonathanedey
approved these changes
Mar 2, 2026
Collaborator
jonathanedey
left a comment
jonathanedey
left a comment
There was a problem hiding this comment.
LGTM, with one nit on doc string.
Comment on lines
+431
to
+442
|
|
||
| /** | ||
| * A boolean indicating whether the message is allowed to be delivered in | ||
| * a low-bandwidth environment. | ||
| */ | ||
| bandwidthConstrainedOk?: boolean; | ||
|
|
||
| /** | ||
| * A boolean indicating whether the message is allowed to be delivered | ||
| * via satellite. | ||
| */ | ||
| restrictedSatelliteOk?: boolean; |
Collaborator
There was a problem hiding this comment.
It would be nice to have the docs here match the other SDKs as well. But I'll hold off on changing it until it's TW approved in one of the other SDKs.
/**
* A boolean indicating whether messages will be allowed to be delivered to
* the app while the device is on a bandwidth constrained network.
*/
bandwidthConstrainedOk?: boolean;
/**
* A boolean indicating whether messages will be allowed to be delivered to
* the app while the device is on a restricted satellite network.
*/
restrictedSatelliteOk?: boolean;
There was a problem hiding this comment.
This looks good to me! I believe I approved this in one of the other SDKs as well
OrlandriaH-G
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two new optional boolean properties,
bandwidthConstrainedOkandrestrictedSatelliteOk, to theAndroidConfigtype in the messaging API.This change includes:
AndroidConfiginterface insrc/messaging/messaging-api.ts.src/messaging/messaging-internal.ts.test/unit/messaging/messaging.spec.tsto cover the new properties.