Skip to content

Fix mixed explicit and implicit chapter contexts#310

Merged
fingolfin merged 2 commits intomasterfrom
codex/fix-issue-279
Mar 3, 2026
Merged

Fix mixed explicit and implicit chapter contexts#310
fingolfin merged 2 commits intomasterfrom
codex/fix-issue-279

Conversation

@fingolfin
Copy link
Member

Create missing chapter and section nodes lazily when grouped items
are inserted so mixed explicit and auto-generated layouts do not
crash.

Fixes #279.

Co-authored-by: Codex codex@openai.com

Create missing chapter and section nodes lazily when grouped items
are inserted so mixed explicit and auto-generated layouts do not
crash.

Fixes #279.

Co-authored-by: Codex <codex@openai.com>
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.82%. Comparing base (3d0e6cf) to head (d4ca386).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
gap/DocumentationTree.gi 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   84.69%   84.82%   +0.12%     
==========================================
  Files          13       13              
  Lines        2281     2280       -1     
==========================================
+ Hits         1932     1934       +2     
+ Misses        349      346       -3     
Files with missing lines Coverage Δ
gap/DocumentationTree.gi 94.04% <66.66%> (+0.23%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin fingolfin merged commit 9dea6e7 into master Mar 3, 2026
7 of 8 checks passed
@fingolfin fingolfin deleted the codex/fix-issue-279 branch March 3, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: if one .gd file has a @Chapter and @Section but another doesn't an unhelpful error is raised

1 participant