Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Azure Pricing skill to the skills catalog, intended to guide agents in fetching Azure Retail Prices API data and turning it into cost estimates with supporting reference material.
Changes:
- Introduces
skills/azure-pricing/SKILL.mdwith step-by-step instructions, filter guidance, and response parsing notes for the Azure Retail Prices API. - Adds bundled reference docs for region names, service names, and cost estimation formulas under
skills/azure-pricing/references/. - Registers the new skill in
docs/README.skills.md.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| skills/azure-pricing/SKILL.md | New skill instructions for querying Azure Retail Prices API and producing cost estimates. |
| skills/azure-pricing/references/SERVICE-NAMES.md | Reference mapping of common Azure services to serviceName values. |
| skills/azure-pricing/references/REGIONS.md | Reference mapping of display region names to armRegionName. |
| skills/azure-pricing/references/COST-ESTIMATOR.md | Reference formulas/templates for monthly/annual cost estimation. |
| docs/README.skills.md | Adds azure-pricing to the skills index with bundled assets listed. |
|
|
||
| | Field | Type | Example | | ||
| |---|---|---| | ||
| | `serviceName` | string (exact, case-sensitive) | `'Azure Functions'`, `'Virtual Machines'`, `'Azure Blob Storage'` | |
There was a problem hiding this comment.
The serviceName examples here don’t match the values used elsewhere in this skill and in references/SERVICE-NAMES.md. For example, Azure Functions is shown as 'Azure Functions' but the reference (and your example filters below) use 'Functions', and Blob Storage is under the Storage service (serviceName eq 'Storage') rather than 'Azure Blob Storage'. Updating these examples will prevent users from building filters that return empty results.
| | `serviceName` | string (exact, case-sensitive) | `'Azure Functions'`, `'Virtual Machines'`, `'Azure Blob Storage'` | | |
| | `serviceName` | string (exact, case-sensitive) | `'Functions'`, `'Virtual Machines'`, `'Storage'` | |
| | Azure Storage (Blob, Files, Queues, Tables) | `Storage` | | ||
| | Azure NetApp Files | `Azure NetApp Files` | | ||
| | Azure Backup | `Backup` | | ||
| | Azure Data Box | `Data Box` | |
There was a problem hiding this comment.
Azure Backup is listed here with serviceName value Backup, but the same service is later listed again under “Management & Monitoring” with serviceName value Azure Backup. Having two different serviceName values for the same service in this reference is contradictory and will confuse users; please reconcile to a single correct value (or explain why there are multiple values if that’s the case).
| | Azure Monitor | `Azure Monitor` | | ||
| | Azure Log Analytics | `Log Analytics` | | ||
| | Azure Key Vault | `Key Vault` | | ||
| | Azure Backup | `Azure Backup` | |
There was a problem hiding this comment.
This entry for Azure Backup uses serviceName value Azure Backup, but earlier in this same document Azure Backup is mapped to Backup. Please make these consistent (or add a note clarifying when each value applies) so consumers don’t end up with filters that return no results.
| | Azure Backup | `Azure Backup` | | |
| | Azure Backup | `Backup` | |
aaronpowell
left a comment
There was a problem hiding this comment.
Can you add this to the azure-cloud-development plugin? I think that'd be a good item to include in the plugin.
And just to make sure I correctly understand - it is intended to create an API call to the pricing calculator to ensure the correct prices are available to the agent, the info in the COST-ESTIMATOR.md is more to guide the model on how to form things correct?
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.Description
this is to add a new skill to estimate azure costs
Type of Contribution
Additional Notes
By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.