Wrong default for [server].SSH_ROOT_PATH

[jedix]

Description

After not setting SSH_ROOT_PATH in the [server] section and then trying to add an public SSH key, the following error occurs:

AddPublicKey, addKey: mkdir /home/git: permission denied

But the home directory for the user git is not /home/git but rather /srv/data/git in my case.

According to the documentation, SSH_ROOT_PATH defaults to ~/.ssh, which would be fine.
But in the administration interface (gitea-url/-/admin/config), it shows SSH_ROOT_PATH to be /home/git/.ssh

Setting it manually to ~/.ssh fixes the issue.

Gitea Version

1.25.2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

https://gist.github.com/jedix/d72a8fa06d86b7910f544fcd3d9a1509

Screenshots

Git Version

2.53.0

Operating System

Fedora 43

How are you running Gitea?

Downloaded the binary and running as a systemd service.

Database

MySQL/MariaDB

[jedix]

Setting it manually to ~/.ssh fixes the issue.

I was wrong. It seemed to fix the issue. But in reality, a new directory /var/lib/gitea/~ was created in which there was the directory .ssh in which the file authorized_keys was populated with the newly added key.
None of this allowed me to actually use the key.

What really fixed the issue, was setting SSH_ROOT_PATH to /srv/data/git. With this setting, the already existing authorized_keys file was updated correctly.