Add Promise.allSettled and AllSettledResultElement#183
Open
niloc132 wants to merge 1 commit intogoogle:masterfrom
Open
Add Promise.allSettled and AllSettledResultElement#183niloc132 wants to merge 1 commit intogoogle:masterfrom
niloc132 wants to merge 1 commit intogoogle:masterfrom
Conversation
Contributor
Author
|
This is a quick sketch of what this likely should look like, based on Promise.all() and race(). Note that the AllSettledResultElement would technically have setters and a create() method, but there is no plausible mechanism for a user to create these elements directly. Likely there are some specific desired |
jDramaix
reviewed
Mar 4, 2026
| @@ -0,0 +1,20 @@ | |||
| package elemental2.promise; | |||
Member
There was a problem hiding this comment.
Could you add the Copyright header ?
| * Represents an element of the array returned by Promise.allSettled(). | ||
| * @param <VALUE> the type of the succeeded promise. | ||
| */ | ||
| @JsType(isNative = true) |
Member
There was a problem hiding this comment.
@jstype(isNative = true, name = "Promise.AllSettledResultElement", namespace = JsPackage.GLOBAL)
| * @param <VALUE> the type of the succeeded promise. | ||
| */ | ||
| @JsType(isNative = true) | ||
| public interface AllSettledResultElement<VALUE> { |
Member
There was a problem hiding this comment.
We should nullmarked this type:
@NullMarked
public interface AllSettledResultElement<VALUE extends @Nullable Object>
and value and reason should be nullable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #182