feat: Use grpc.WithStatsHandler to record gRPC metrics#4644
Draft
bryanhuhta wants to merge 1 commit intomainfrom
Draft
feat: Use grpc.WithStatsHandler to record gRPC metrics#4644bryanhuhta wants to merge 1 commit intomainfrom
bryanhuhta wants to merge 1 commit intomainfrom
Conversation
bryanhuhta
added
the
DO NOT MERGE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a basic
stats.Handlerto manage recording metrics for gRPC clients and servers. This is an improvement (possible minor) over using an interceptor because it will more precisely report timings and byte sizes as it gets execute outside of the interceptor evaluation chain.I plan to experiment with using this over interceptors to see if there's any tangible difference in measurements (both in accuracy and performance).
I have not tested this so I cannot vouch for its accuracy yet.