Fix: reset document status to RUNNING when tasks recover from transient error#13293
Open
Br1an67 wants to merge 1 commit intoinfiniflow:mainfrom
Open
Fix: reset document status to RUNNING when tasks recover from transient error#13293Br1an67 wants to merge 1 commit intoinfiniflow:mainfrom
Br1an67 wants to merge 1 commit intoinfiniflow:mainfrom
Conversation
When a task temporarily fails (progress=-1) and the periodic update_progress sync marks the document as FAIL, the status was not reset back to RUNNING when the task recovered and continued. This happened because _sync_progress used doc.run as the default status, and when finished=False, neither the FAIL nor DONE branch updated it, leaving it stuck at FAIL.
dosubot
bot
added
size:XS
4 tasks
|
Does your fix also handle the incorrect progress = -1.0 value? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fixes #13285
When a parsing task encounters a transient error (e.g., LLM overloaded), it temporarily sets
task.progress = -1. If the periodic_sync_progressruns during this window, it marks the document as FAIL (doc.run = TaskStatus.FAIL). When the task recovers and continues processing (e.g.,task.progress = 0.5), the next_sync_progressiteration readsstatus = doc.run(which is FAIL) as the default. Sincefinished = False(task is still running), neither the FAIL nor DONE branch updates the status, leaving the document stuck at FAIL even though processing is actively continuing.This PR adds an explicit
elseclause in_sync_progressto reset the document status back toRUNNINGwhen there are still unfinished tasks.Type of change