chore: remove tests and core/rag from type checker ignores#32802
chore: remove tests and core/rag from type checker ignores#32802VedantMadane wants to merge 2 commits intolanggenius:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the type checker configurations for both pyrefly and pyright by removing the 'tests/' and 'core/rag' directories from their respective exclusion lists. This change ensures that static type analysis is performed on these previously ignored parts of the codebase, aiming to enhance code quality and proactively identify type-related issues. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enables type checking for the tests/ and core/rag directories by removing them from the exclude lists in pyrefly.toml and pyrightconfig.json. The changes are straightforward and correctly implement the intended configuration update. I have reviewed the changes and found no issues.
Fixes #32779.
Removed \ ests/\ and \core/rag\ from the \exclude\ arrays in both \�pi/pyrefly.toml\ and \�pi/pyrightconfig.json\ to enable type checking for these directories, as requested. Kept .venv\ and \migrations/\ ignored.