Skip to content

chore: remove tests and core/rag from type checker ignores#32802

Open
VedantMadane wants to merge 2 commits intolanggenius:mainfrom
VedantMadane:refactor/type-checker-includes
Open

chore: remove tests and core/rag from type checker ignores#32802
VedantMadane wants to merge 2 commits intolanggenius:mainfrom
VedantMadane:refactor/type-checker-includes

Conversation

@VedantMadane
Copy link

Fixes #32779.

Removed \ ests/\ and \core/rag\ from the \exclude\ arrays in both \�pi/pyrefly.toml\ and \�pi/pyrightconfig.json\ to enable type checking for these directories, as requested. Kept .venv\ and \migrations/\ ignored.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 2, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the type checker configurations for both pyrefly and pyright by removing the 'tests/' and 'core/rag' directories from their respective exclusion lists. This change ensures that static type analysis is performed on these previously ignored parts of the codebase, aiming to enhance code quality and proactively identify type-related issues.

Highlights

  • Type Checker Configuration: Removed 'tests/' and 'core/rag' from the 'project-excludes' list in 'api/pyrefly.toml', enabling type checking for these directories.
  • Type Checker Configuration: Removed 'tests/' and 'core/rag' from the 'exclude' list in 'api/pyrightconfig.json', enabling type checking for these directories.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • api/pyrefly.toml
    • Removed "tests/" from the project-excludes array.
    • Removed "core/rag" from the project-excludes array.
  • api/pyrightconfig.json
    • Removed "tests/" from the exclude array.
    • Removed "core/rag" from the exclude array.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables type checking for the tests/ and core/rag directories by removing them from the exclude lists in pyrefly.toml and pyrightconfig.json. The changes are straightforward and correctly implement the intended configuration update. I have reviewed the changes and found no issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor/Chore] remove more ignore in type checker

1 participant