feat: commonizes several FDv2 related types in Server#144
Merged
tanderson-ld merged 5 commits intomainfrom Feb 27, 2026
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/PollingBase.java
Show resolved
Hide resolved
kinyoklion
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the third installment of commonizing FDv2 related types. There should be no behavioral changes in this PR.
Note
Medium Risk
Broad refactor across data-source and data-store update paths to switch to shared
com.launchdarkly.sdk.fdv2types plus an internal dependency bump, which could surface integration/compatibility issues despite intended no behavior change.Overview
Commonizes FDv2 model types by switching server SDK code from internal/
DataStoreTypesFDv2 classes to sharedcom.launchdarkly.sdk.fdv2types (Selector,ChangeSet,ChangeSetType,SourceResultType,SourceSignal) and deletingDataStoreTypes.ChangeSet/ChangeSetType.Updates all affected interfaces/implementations and adapters (
TransactionalDataStore,TransactionalDataSourceUpdateSink,FDv2SourceResult, polling/streaming/file/test sources) to use the newChangeSetgeneric shape, and adjusts minor edge-case handling (e.g.,sortChangesetnull-data guard; polling 304 now emits an empty data list).Build changes bump
launchdarkly-java-sdk-internalto1.9.0and includecom.launchdarkly.sdk.fdv2in the package list used for OSGi/shading; tests are updated accordingly.Written by Cursor Bugbot for commit aeda35a. This will update automatically on new commits. Configure here.
BEGIN_COMMIT_OVERRIDE
feat: commonizes several FDv2 related types
END_COMMIT_OVERRIDE