Skip to content

feat: commonizes several FDv2 related types in Server#144

Merged
tanderson-ld merged 5 commits intomainfrom
ta/SDK-1817/commonizing-fdv2-source-types-server
Feb 27, 2026
Merged

feat: commonizes several FDv2 related types in Server#144
tanderson-ld merged 5 commits intomainfrom
ta/SDK-1817/commonizing-fdv2-source-types-server

Conversation

@tanderson-ld
Copy link
Contributor

@tanderson-ld tanderson-ld commented Feb 27, 2026

This PR is the third installment of commonizing FDv2 related types. There should be no behavioral changes in this PR.


Note

Medium Risk
Broad refactor across data-source and data-store update paths to switch to shared com.launchdarkly.sdk.fdv2 types plus an internal dependency bump, which could surface integration/compatibility issues despite intended no behavior change.

Overview
Commonizes FDv2 model types by switching server SDK code from internal/DataStoreTypes FDv2 classes to shared com.launchdarkly.sdk.fdv2 types (Selector, ChangeSet, ChangeSetType, SourceResultType, SourceSignal) and deleting DataStoreTypes.ChangeSet/ChangeSetType.

Updates all affected interfaces/implementations and adapters (TransactionalDataStore, TransactionalDataSourceUpdateSink, FDv2SourceResult, polling/streaming/file/test sources) to use the new ChangeSet generic shape, and adjusts minor edge-case handling (e.g., sortChangeset null-data guard; polling 304 now emits an empty data list).

Build changes bump launchdarkly-java-sdk-internal to 1.9.0 and include com.launchdarkly.sdk.fdv2 in the package list used for OSGi/shading; tests are updated accordingly.

Written by Cursor Bugbot for commit aeda35a. This will update automatically on new commits. Configure here.

BEGIN_COMMIT_OVERRIDE
feat: commonizes several FDv2 related types
END_COMMIT_OVERRIDE

@tanderson-ld tanderson-ld requested a review from a team as a code owner February 27, 2026 14:36
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@tanderson-ld tanderson-ld merged commit f1f42f8 into main Feb 27, 2026
23 of 36 checks passed
@tanderson-ld tanderson-ld deleted the ta/SDK-1817/commonizing-fdv2-source-types-server branch February 27, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants