fix(deps): move type-fest from devDependencies to dependencies#7433
Open
fix(deps): move type-fest from devDependencies to dependencies#7433
Conversation
type-fest types (SetRequired, SetOptional, RequiredDeep, Entries) are used in source files that produce published .d.ts declarations. With type-fest only in devDependencies, consumers get TS2307 errors when type-fest is not available transitively (e.g. after globals v14+ dropped its type-fest dependency). Resolves #6629 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: f8f7d73 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7433 +/- ##
==========================================
- Coverage 3.55% 3.54% -0.02%
==========================================
Files 489 490 +1
Lines 48774 48938 +164
Branches 765 766 +1
==========================================
Hits 1734 1734
- Misses 47040 47204 +164
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #6629
type-festfromdevDependenciestodependenciesinpackages/mermaid/package.jsontype-festtypes (SetRequired,SetOptional,RequiredDeep,Entries) are used in 5 source files whose declarations are published in thedist/.d.tsfiles. Withtype-festonly indevDependencies, consumers getTS2307: Cannot find module 'type-fest'errors whentype-festis not available transitively — which happens when packages likeglobals(v14+) drop their owntype-festdependency.Classification
package.jsonmanifest)Verification
pnpm build:mermaid)type-festindependencies, not indevDependencies🤖 Generated with Claude Code