Skip to content

fix(deps): move type-fest from devDependencies to dependencies#7433

Open
knsv wants to merge 1 commit intodevelopfrom
bug/6629_missing-type-fest-dependency
Open

fix(deps): move type-fest from devDependencies to dependencies#7433
knsv wants to merge 1 commit intodevelopfrom
bug/6629_missing-type-fest-dependency

Conversation

@knsv
Copy link
Collaborator

@knsv knsv commented Mar 2, 2026

Summary

Resolves #6629

  • Moved type-fest from devDependencies to dependencies in packages/mermaid/package.json

type-fest types (SetRequired, SetOptional, RequiredDeep, Entries) are used in 5 source files whose declarations are published in the dist/ .d.ts files. With type-fest only in devDependencies, consumers get TS2307: Cannot find module 'type-fest' errors when type-fest is not available transitively — which happens when packages like globals (v14+) drop their own type-fest dependency.

Classification

  • Change type: Dependency/packaging fix
  • Breaking change: No
  • Shared code touched: No (only package.json manifest)

Verification

  • Lint: passed
  • Build: passed (pnpm build:mermaid)
  • Dependency check: type-fest in dependencies, not in devDependencies
  • Changeset: generated (patch)
  • TDD: N/A — packaging fix, no code logic changed
  • Visual spot-check: N/A — no rendering changes
  • Full e2e: not run — no code changes

🤖 Generated with Claude Code

type-fest types (SetRequired, SetOptional, RequiredDeep, Entries) are
used in source files that produce published .d.ts declarations. With
type-fest only in devDependencies, consumers get TS2307 errors when
type-fest is not available transitively (e.g. after globals v14+ dropped
its type-fest dependency).

Resolves #6629

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@netlify
Copy link

netlify bot commented Mar 2, 2026

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit f8f7d73
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/69a549837438370008c7a91c
😎 Deploy Preview https://deploy-preview-7433--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2026

🦋 Changeset detected

Latest commit: f8f7d73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Mar 2, 2026
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 2, 2026

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/@mermaid-js/examples@7433

mermaid

npm i https://pkg.pr.new/mermaid@7433

@mermaid-js/layout-elk

npm i https://pkg.pr.new/@mermaid-js/layout-elk@7433

@mermaid-js/layout-tidy-tree

npm i https://pkg.pr.new/@mermaid-js/layout-tidy-tree@7433

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/@mermaid-js/mermaid-zenuml@7433

@mermaid-js/parser

npm i https://pkg.pr.new/@mermaid-js/parser@7433

@mermaid-js/tiny

npm i https://pkg.pr.new/@mermaid-js/tiny@7433

commit: 5e08d7e

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.54%. Comparing base (3b5f67d) to head (f8f7d73).
⚠️ Report is 9 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #7433      +/-   ##
==========================================
- Coverage     3.55%   3.54%   -0.02%     
==========================================
  Files          489     490       +1     
  Lines        48774   48938     +164     
  Branches       765     766       +1     
==========================================
  Hits          1734    1734              
- Misses       47040   47204     +164     
Flag Coverage Δ
unit 3.54% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@argos-ci
Copy link

argos-ci bot commented Mar 2, 2026

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Mar 2, 2026, 8:38 AM

@knsv knsv marked this pull request as ready for review March 2, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug / Error Something isn't working or is incorrect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing dependency for type-fest

1 participant