Fix XXE vulnerability in DOCX preprocessing (#1565)#1582
Open
KevinChen1994 wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix XXE vulnerability in DOCX preprocessing (#1565)#1582KevinChen1994 wants to merge 1 commit intomicrosoft:mainfrom
KevinChen1994 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Replace unsafe `xml.etree.ElementTree` with `defusedxml.ElementTree` in `converter_utils/docx/pre_process.py`. The `ET.fromstring()` call parses XML content extracted from user-supplied DOCX files, which is vulnerable to XML External Entity (XXE) injection and Billion Laughs (exponential entity expansion) attacks. `defusedxml` is already a core dependency of the project and is used in other converters (omml.py, _rss_converter.py, _epub_converter.py). This change makes the DOCX preprocessor consistent with the rest of the codebase. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xml.etree.ElementTreewithdefusedxml.ElementTreeinconverter_utils/docx/pre_process.pyto prevent XXE (XML External Entity)injection attacks
ET.fromstring()call parses XML content extracted from user-suppliedDOCX files, making it vulnerable to XXE injection and Billion Laughs
(exponential entity expansion) attacks
defusedxmlis already a core dependency of the project and is usedconsistently in other converters (
omml.py,_rss_converter.py,_epub_converter.py)Fixes #1565
Test plan