apparmor: use "filepath" instead of "path", and fix linting (gosec)#11
Open
apparmor: use "filepath" instead of "path", and fix linting (gosec)#11
Conversation
Member
thaJeztah
commented
Feb 19, 2026
thaJeztah
commented
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Feb 19, 2026
|
|
||
| // Install to a temporary directory. | ||
| tmpFile, err := os.CreateTemp("", name) | ||
| tmpFile, err := os.CreateTemp("", "apparmor-profile-") |
Member
Author
There was a problem hiding this comment.
I don't think there's a need for the temp-file name to match the profile name; it's just a temporary file we use to load the profile?
thaJeztah
force-pushed
the
apparmor_linting
branch
2 times, most recently
from
6c6a783 to
73ab97b
Compare
Error: /home/runner/work/profiles/profiles/apparmor/apparmor.go:82:16: G703: Path traversal via taint analysis (gosec)
_ = os.Remove(tmpFile.Name())
^
Error: /home/runner/work/profiles/profiles/apparmor/apparmor.go:129:7: G204: Subprocess launched with variable (gosec)
c := exec.Command("apparmor_parser", "-Kr", profilePath)
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
apparmor_linting
branch
from
73ab97b to
536f988
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.