fix(editor): Do not show "Set up error notifications" suggestion when activating an error workflow

[RomanDavydchuk]

Summary

If you were to activate a workflow that contains the Error trigger and the production checklist appears - it'll have "Set up error notifications" item, which doesn't make that much sense.

This PR fixes that:

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-4524/error-checklist-item-also-showing-in-error-workflow

Review / Merge checklist

• PR title and summary are descriptive. (conventions)
• Docs updated or follow-up ticket created.
• Tests included.
• PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

[cubic-dev-ai]

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/frontend/editor-ui/src/app/components/WorkflowProductionChecklist.vue">

<violation number="1" location="packages/frontend/editor-ui/src/app/components/WorkflowProductionChecklist.vue:70">
P1: Custom agent: **Tests**

Add tests for the new error-workflow checklist suppression. The Community PR Guidelines require tests for changes like this, and the current diff adds behavior in `WorkflowProductionChecklist.vue` without any test coverage.</violation>
</file>

Architecture diagram

sequenceDiagram
    participant User
    participant Comp as WorkflowProductionChecklist (Vue)
    participant State as Workflow State
    participant UI as Suggested Actions UI

    User->>Comp: Activate Workflow / Open Checklist
    Comp->>State: Access workflow.nodes & settings
    State-->>Comp: Return node array and errorWorkflow settings

    Note over Comp: NEW: Check if current workflow is an Error Workflow
    Comp->>Comp: isErrorWorkflow = nodes.some(type === 'ERROR_TRIGGER' && !disabled)

    Note over Comp: CHANGED: Compute availableActions
    alt isErrorWorkflow === true
        Comp->>Comp: NEW: Exclude "Set up error notifications" from actions
    else isErrorWorkflow === false
        opt !workflow.settings.errorWorkflow && !ignored
            Comp->>Comp: Include "Set up error notifications" action
        end
    end

    Comp->>Comp: Include other actions (e.g., "Set up time saved")
    Comp->>UI: Render filtered list of actions
    UI-->>User: Display Production Checklist

Loading

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[codecov]

Bundle Report

Changes will increase total bundle size by 224 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
editor-ui-esm	42.4MB	224 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: editor-ui-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
assets/WorkflowLayout-*.js	224 bytes	88.01kB	0.26%

Files in assets/WorkflowLayout-*.js:

• ./src/app/components/WorkflowProductionChecklist.vue → Total Size: 189 bytes

[cubic-dev-ai]

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/frontend/editor-ui/src/app/components/WorkflowProductionChecklist.vue">

<violation number="1" location="packages/frontend/editor-ui/src/app/components/WorkflowProductionChecklist.vue:129">
P1: This change is behaviorally a no-op (only reorders equivalent conditions), so it does not implement the NODE-4524 bug fix.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}