Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
No issues found across 4 files
Architecture diagram
sequenceDiagram
participant UI as Chat UI
participant CHS as ChatHubService
participant DB as Message Repository
participant WES as WorkflowExecutionService
participant MN as Restore Chat Memory Node
participant CT as Chat Trigger Node
Note over UI,CT: Message Regeneration Flow
UI->>CHS: regenerateAIMessage(retryId)
CHS->>DB: getManyBySessionId(sessionId)
DB-->>CHS: full conversation history
CHS->>CHS: Identify target AI message & preceding human message
Note right of CHS: CHANGED: history.splice(lastHumanMessageIndex)<br/>removes the trigger message from history<br/>to prevent double-injection.
CHS->>WES: executeChatWorkflow(workflow, executionData)
rect rgb(20, 30, 50)
Note over WES,CT: Workflow Execution Context
WES->>MN: NEW: Inject truncated history (excluding last human message)
WES->>CT: Inject last human message as "current" trigger input
end
CT->>WES: Continue workflow turn...
WES-->>CHS: executionId & stream
CHS-->>UI: stream response tokens
Note over CHS,DB: Post-Execution
CHS->>DB: Save new AI response
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When user regenerated messages on Chat hub we accidentally included the last human message both oh the chat history and as a new human message triggering that turn.
Instead don't include the human message on the history, as it gets replayed which inserts it into the memory again.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CHA-83/bug-duplicate-user-message-sent-on-regeneration
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)