Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
cubic analysis
No issues found across 1 file
Linked issue analysis
Linked issue: CHA-154: Bug - Position chat greetings text to the middle
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Center the chat greetings prompt for base LLM chats (non-agent models). | Applied greetingsCentered class when not an agent model |
| ✅ | Keep agent models' greetings positioned at the top (do not center agent chats). | Introduced isAgentModel and isAgentNewSession layout class |
| ✅ | Only apply centering when showing the greeting for a new session. | ChatGreetings is rendered only when isNewSession (v-if) |
| ✅ | Add computed detection for agent vs base LLM models. | Added isAgentModel computed using selectedModel and isLlmProvider |
| ✅ | Add CSS rules to center the greetings (flex centering) and maintain agent spacing. | Added .greetingsCentered flex center and .isAgentNewSession padding-top |
Architecture diagram
sequenceDiagram
participant CV as ChatView (Vue Component)
participant CS as ChatStore (State)
participant CG as ChatGreetings (Sub-component)
Note over CV,CS: Runtime Layout Initialization
CV->>CS: Access selectedModel property
CS-->>CV: Return ChatModelDto
CV->>CV: NEW: Compute isAgentModel (Boolean)
Note right of CV: Checks if provider is NOT a standard LLM
alt isNewSession is TRUE
CV->>CV: CHANGED: Determine Layout Class
alt isAgentModel is TRUE
CV->>CV: Apply .isAgentNewSession (Padding-top)
else isAgentModel is FALSE (Base LLM)
CV->>CV: NEW: Apply .greetingsCentered (Flex-center)
end
CV->>CG: Render Greetings Component
Note over CV,CG: NEW: Inject .greetingsCentered class via props
else isExistingSession
CV->>CV: Apply .isExistingSession (Standard layout)
end
Note over CV: Browser applies CSS Flexbox rules based on dynamic classes
This comment was marked as spam.
This comment was marked as spam.
Bundle ReportChanges will increase total bundle size by 607 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: editor-ui-esmAssets Changed:
Files in
|
autologie
approved these changes
Mar 3, 2026
Contributor
autologie
left a comment
There was a problem hiding this comment.
Perhaps we'll add suggested prompts for base LLM chats too later
Maybe we haven't settled yet, but I believe this is the plan
https://www.figma.com/design/RVJgBrL0fXTCvreYqfWAlL/ChatHub-Scratchpad-2026?node-id=245-2132&t=JEnFftR79LH9v78l-0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Now that chat suggested prompts are out we (accidentally?) changed the layout also on base LLM chats, positioning the chat greeting to the top. This looks pretty empty, lets position it to the center instead.
Perhaps we'll add suggested prompts for base LLM chats too later, but as we don't have them now lets make this look slightly better.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CHA-154/bug-position-chat-greetings-text-to-the-middle
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)