install.sh: respect git config --global clone.defaultRemoteName

[ryan-williams]

Fixes #3547

Uses git config --global clone.defaultRemoteName, if it is set, otherwise falls back to origin.

[ljharb]

Can you add some tests?

[ryan-williams]

Thanks. I looked at install_nvm_from_git but am not sure how I should test this there. Would a GHA be a better place to test it?

Also it looks like the 2 GHAs that failed are also failing on master, so I'm assuming I can ignore those here.

[ljharb]

Yes, GHA is the better place to add new tests, and yes, those v0.40.0 tests will fail forever and that's ok :-)

[Snapp949]

👍

[ryan-williams]

I can make a standalone GHA that tests this, is that what you have in mind @ljharb?

I looked at the existing tests a bit last month, but couldn't get oriented.

[ljharb]

It'd be best to add it inside the existing test suite

[LemmingAvalanche]

I just encountered this problem. Thanks for fixing.

My idea was to force the clone to use origin. Then nothing else needs to change I guess?

command git clone --origin=origin "$(nvm_source)" --depth=1 "${INSTALL_DIR}"

[ljharb]

@LemmingAvalanche what will that do on a git version that doesn't support --origin?

[LemmingAvalanche]

@LemmingAvalanche what will that do on a git version that doesn't support --origin?

--origin has been part of git(1) since 1.4.4. --depth has been part of git(1) since 1.5.0.

But you can override the config variable instead of using --origin.

command git -c clone.defaultRemoteName=origin clone "$(nvm_source)" --depth=1 "${INSTALL_DIR}"

But clone.defaultRemoteName is newer: since 2.30.0.

[ljharb]

Thanks! We can use --origin then, that seems like a great change for this PR. If you'd like to do that, please don't open a new PR, just comment here with a branch link and i'll pull in the changes.