fix: avoid glob expansion errors when no node versions installed

[tennisleng]

Summary

Fixes #3727

When no node versions are installed, nvm ls produces errors like:

find: /path/.nvm/versions/node/*: No such file or directory

This happens because bash expands * literally when nullglob is not set and the directory is empty.

Solution

• Build find arguments dynamically without shell glob expansion
• Use find DIR -mindepth 1 -maxdepth 1 instead of find DIR/*
• Suppress stderr from find to handle edge cases gracefully
• Deduplicate directories before passing to find

Before

$ nvm ls
find: /Users/balupton/.nvm/versions/node/*: No such file or directory
find: /Users/balupton/.nvm/versions/node/*: No such file or directory
-> system

After

$ nvm ls
-> system

Testing

• Verified with empty ~/.nvm/versions/node/ directory
• Verified with existing node versions installed

[ljharb]

Instead of altering a bunch of the logic, could we perhaps just disable nullglob when needed for the nvm_ls invocation?

[ljharb]

so this kind of works, but relies on nothing exiting prior to the restoration.

i was thinking instead, of wrapping every call to nvm_ls in this nullglob check, and turning it off in a subshell in which nvm_ls is invoked - that way, it's impossible have the nullglob change persist.

[ljharb]

Awesome! Now we need a test that has the wrong nullglob setting and will prevent regressions :-)

[tennisleng]

Awesome! Now we need a test that has the wrong nullglob setting and will prevent regressions :-)

done

[tennisleng]

@ljharb can you review this?

[ljharb]

Unfortunately the test passes even without the fix.