Indicate MCP server url in config UI#22150
Open
NobodysNightmare wants to merge 1 commit intorelease/17.2from
Open
Indicate MCP server url in config UI#22150NobodysNightmare wants to merge 1 commit intorelease/17.2from
NobodysNightmare wants to merge 1 commit intorelease/17.2from
Conversation
Giving admins quick access to this URL, because it will be required during setup of a client.
Kharonus
approved these changes
Mar 3, 2026
Member
Kharonus
left a comment
Kharonus
left a comment
There was a problem hiding this comment.
LGTM, just one question for understanding.
|
|
||
| <%= | ||
| render(Primer::OpenProject::InputGroup.new(input_width: :large)) do |input_group| | ||
| input_group.with_text_input( |
Member
There was a problem hiding this comment.
❓ maybe you can quickly tell me: Why is it not needed to give the text input itself a readonly? I see it is used in the form with html_content, and not as `text_field', but if only looking at code I would have expected the input is active, but simply not attached to the form semantically.
Contributor
Author
There was a problem hiding this comment.
Honestly, I asked this myself. I copied this code from our storage forms, specifically the redirect_url over there. I'd also have expected from the code, that it's editable. But it isn't. I didn't dig deeper and just accepted that copy&paste worked and gave me the behaviour I wanted.
🙈 🙈 🙈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Giving admins quick access to this URL, because it will be required during setup of a client.
Visual appearance was clarified with UX already.