Improved pull request "Files Changed" experience feedback #163932
Replies: 2876 comments 1170 replies
-
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
|
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
|
The tab for |
Beta Was this translation helpful? Give feedback.
-
|
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
On the Files changed tab I can only see 19 files out of 66. Why? |
Beta Was this translation helpful? Give feedback.
-
|
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
Beta Was this translation helpful? Give feedback.
-
|
It doesn't always seem to remember if hide whitespace was turned on. |
Beta Was this translation helpful? Give feedback.
-
|
Please include the commit hash along with files changed when viewing submodule changes |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Why is there not a Deselect/Select all on the filters? It's incredibly cumbersome on each PR to have to select what files you actually want to see |
Beta Was this translation helpful? Give feedback.
-
Draft comments should be available when using next/previous buttons in this review. It's incredibly disconcerting when things disappear -- I was very worried my comments were lost forever. |
Beta Was this translation helpful? Give feedback.
-
|
"Show outdated comments" still does not show outdated comments. That preview is enabled by default for everyone. How?.. Just – how?.. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
When opening the comments panel, unresolved comments should always come first. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Ok when I click a review comment to scroll to, it does nothing 50% of the time, 30% of the time it jumps to a random spot, and 10% of the time it doesn't show up when I scroll to it, and 5% of the time it scrolls to it, then jumps to a completely different spot, the 5% of the time it works Also just collapsing files/marking as viewed is just nearly completely broken. On large PRs both the old and new views, just suck. Old one is too laggy, new one just doesn't work and it is jumping me around everywhere, and makes code review impossible |
Beta Was this translation helpful? Give feedback.
-
|
In a previous version of the pull request files changed viewer, I had improved the experience myself by adding the following user script using the Tampermonkey extension: User script that autmatically collapsed all file diffs if there were more than 3// ==UserScript==
// @name Auto-collase github PR diff files
// @namespace http://tampermonkey.net/
// @version 2026-01-24
// @description Auto-collase github PR diff files
// @author k98kurz
// @match https://github.com/*/*/pull/*/files?target=https://github.com
// @icon https://www.google.com/s2/favicons?sz=64&domain=github.com
// @grant none
// ==/UserScript==
(function() {
setTimeout(() => {
const buttons = document.querySelectorAll('div.file-header > div.file-info > button');
if (buttons.length > 3) {
for (let i=0,l=buttons.length; i<l; i++) {
buttons[i].dispatchEvent(new MouseEvent('click'));
}
}
}, 10000);
})();It used to work, but now it does not, and I cannot find any clean CSS selector to fix it in the new system. It would be immensely helpful if large PRs started with the file diffs closed instead of always open -- it is obnoxious in the extreme to have to scroll for three days just to get to a specific file diff. |
Beta Was this translation helpful? Give feedback.
-
|
Files marked as "Viewed" do not persist when switching away from the "Files changed" view the first time you review a PR. I need to go back to the "Files changed" view, and re-select the "Viewed" box for each of the files I've already viewed, before they persist for future sessions. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
It's annoying that not all comments are shown on the code — I'd like to see if someone other than me resolved a comment. |
Beta Was this translation helpful? Give feedback.

































Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
About the new experience
This updated experience focuses on performance, accessibility, and user productivity. Read more in the changelog.
Tip
If you are not already using the new experience, click the ✨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu.
✨ What's new
If you are coming from the classic experience, the new experience should feel familiar but adds some significant improvements:
✨ Updates
See what's been fixed and improved since the launch of the public preview:
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions