Add ZEND_PARSE_PARAMETERS_NONE to private constructors#21344
Open
jordikroon wants to merge 2 commits intophp:masterfrom
Open
Add ZEND_PARSE_PARAMETERS_NONE to private constructors#21344jordikroon wants to merge 2 commits intophp:masterfrom
jordikroon wants to merge 2 commits intophp:masterfrom
Conversation
jordikroon
requested review from
DanielEScherzer,
devnexen,
dstogov and
ndossche
as code owners
jordikroon
changed the title
Contributor
Author
|
Welp I didn't expect any tests to fail, but the ReflectionAttribute construction test should not have parameters. So those have been removed from the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formally this should also be added to private constructors, which I stumbled on when blocking __PHP_Incomplete_Class.
This PR adds
ZEND_PARSE_PARAMETERS_NONE()to all private constructors. No more follow-up PR's to be expected.