feat: Migrate Session.controller.js to typescript #3958
Open
Piyushrathoree wants to merge 3 commits intoprocessing:developfrom
Open
feat: Migrate Session.controller.js to typescript #3958Piyushrathoree wants to merge 3 commits intoprocessing:developfrom
Piyushrathoree wants to merge 3 commits intoprocessing:developfrom
Conversation
yugalkaushik
suggested changes
Mar 3, 2026
Contributor
There was a problem hiding this comment.
This file does not need to be committed. Please exclude it from the commit.
| next(innerErr); | ||
| return; | ||
| } | ||
| res.json(userResponse(req.user!)); |
Contributor
There was a problem hiding this comment.
A safer approach for this is res.json(userResponse(user));
| {}, | ||
| CreateSessionResponseBody, | ||
| CreateSessionRequestBody | ||
| > = (req: Request, res: Response, next: NextFunction) => { |
Contributor
There was a problem hiding this comment.
Since RequestHandler<> is already used for typing, explicit Request, Response, and NextFunction annotations can be removed for cleaner code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3957
Changes:
server/controllers/session.controller.jsto exactly matching TS file.CreateSessionRequestBody,CreateSessionResponseBody,GetSessionResponseBody, andDestroySessionResponseBodytypes inserver/types/session.ts.@types/express-sessionas a devDependency to allow the global ExpressRequestobject to understandreq.session.destroy().I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123