[io] adjust array length checks in text-based buffers#21463
Open
linev wants to merge 1 commit intoroot-project:masterfrom
Open
[io] adjust array length checks in text-based buffers#21463linev wants to merge 1 commit intoroot-project:masterfrom
linev wants to merge 1 commit intoroot-project:masterfrom
Conversation
Text-based buffers do not have 1GB limitation for object store. But all kind of loops over array indicies made with Int_t so elements count cann't be larger than max int value. Adjust error message
Test Results 22 files 22 suites 3d 3h 45m 16s ⏱️ Results for commit fc82e0a. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pcanal @ferdymercury
Seems to be I overseen your PR #14627
Text-based buffers do not have 1GB limitation for object store.
But all kind of loops over array indexes made with
Int_tso elements count can not be larger than max int value.So only this limit is important.
In JSON array compression can produce small output string from large but empty array.
Overflow of output string buffer (for JSON or XML) is handled by
TString::Append()method and should not play role here.One can adjust error messages in
TBufferFileandTBufferSQL- while you checks 2GB and not 1GB limit.