Skip to content

x86: reserve bl and bh registers to match rbx#153302

Open
CathalMullan wants to merge 1 commit intorust-lang:mainfrom
CathalMullan:rbx
Open

x86: reserve bl and bh registers to match rbx#153302
CathalMullan wants to merge 1 commit intorust-lang:mainfrom
CathalMullan:rbx

Conversation

@CathalMullan
Copy link
Contributor

bl and bh need to be explicitly marked as reserved, as they are sub-registers of rbx, which is reserved by LLVM.

Discovered this while trying to run Graviola through Cranelift, which was becoming corrupted due to the register allocator assigning bl: rust-lang/rustc_codegen_cranelift#1629

cc: @bjorn3

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 2, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 2, 2026

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 15 candidates

@petrochenkov
Copy link
Contributor

r? @Amanieu

@rustbot rustbot assigned Amanieu and unassigned petrochenkov Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants