Add high-priority ICEs to tests/crashes#153321
Open
fanninpm wants to merge 2 commits intorust-lang:mainfrom
Open
Add high-priority ICEs to tests/crashes#153321fanninpm wants to merge 2 commits intorust-lang:mainfrom
fanninpm wants to merge 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
fanninpm
force-pushed
the
test-crashes-add-high-priority
branch
from
f6a896e to
ff5e8c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of when I opened this PR, these two issues, #146965 and #150253, have been assigned as P-high.
Per the dev guide, I am adding these "untracked" crashes to the test suite, if that's okay with the relevant stakeholders.
(I used to contribute to glacier about 5-6 years ago. Let me know if anything needs to change in these tests.)