fix autodiff parsing for non-trait impl#153324
Open
ZuseZ4 wants to merge 1 commit intorust-lang:mainfrom
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
fix-ad-impl-parsing
branch
from
9dcc34a to
d540382
Compare
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
fix-ad-impl-parsing
branch
from
d540382 to
52e0f3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #153322
@Sa4dUs Looks like we missed a case.
But also, going through the code, line 455 seems suspicious to me:
Annotatable::AssocItem(d_fn, Impl { of_trait: false })Are we sure that this should always be an Impl, and never an impl of a trait?
r? @oli-obk