Skip to content

fix(socket): persist outbound edges from locked blocks #3404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 4 commits into from
Mar 3, 2026
Merged

fix(socket): persist outbound edges from locked blocks #3404

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c42e456
fix(socket): persist outbound edges from locked blocks
waleedlatif1 Mar 3, 2026
274ed35
fix(socket): align edge remove protection check with client-side beha…
waleedlatif1 Mar 3, 2026
5a2b2ea
fix(socket): align batch edge protection checks with target-only model
waleedlatif1 Mar 3, 2026
bedb73c
fix(socket): update stale comments for edge protection checks
waleedlatif1 Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 11 additions & 17 deletions apps/sim/socket/database/operations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1246,8 +1246,8 @@ async function handleEdgeOperationTx(tx: any, workflowId: string, operation: str
return false
}

if (isBlockProtected(payload.source) || isBlockProtected(payload.target)) {
logger.info(`Skipping edge add - source or target block is protected`)
if (isBlockProtected(payload.target)) {
logger.info(`Skipping edge add - target block is protected`)
break
}

Expand All @@ -1269,7 +1269,7 @@ async function handleEdgeOperationTx(tx: any, workflowId: string, operation: str
throw new Error('Missing edge ID for remove operation')
}

// Get the edge to check if connected blocks are protected
// Get the edge to check if target block is protected
const [edgeToRemove] = await tx
.select({
sourceBlockId: workflowEdges.sourceBlockId,
Expand All @@ -1283,7 +1283,7 @@ async function handleEdgeOperationTx(tx: any, workflowId: string, operation: str
throw new Error(`Edge ${payload.id} not found in workflow ${workflowId}`)
}

// Check if source or target blocks are protected
// Check if target block is protected
const connectedBlocks = await tx
.select({
id: workflowBlocks.id,
Expand Down Expand Up @@ -1345,11 +1345,8 @@ async function handleEdgeOperationTx(tx: any, workflowId: string, operation: str
return false
}

if (
isBlockProtected(edgeToRemove.sourceBlockId) ||
isBlockProtected(edgeToRemove.targetBlockId)
) {
logger.info(`Skipping edge remove - source or target block is protected`)
if (isBlockProtected(edgeToRemove.targetBlockId)) {
logger.info(`Skipping edge remove - target block is protected`)
break
}

Expand Down Expand Up @@ -1470,14 +1467,11 @@ async function handleEdgesOperationTx(
}

const safeEdgeIds = edgesToRemove
.filter(
(e: EdgeToRemove) =>
!isBlockProtected(e.sourceBlockId) && !isBlockProtected(e.targetBlockId)
)
.filter((e: EdgeToRemove) => !isBlockProtected(e.targetBlockId))
.map((e: EdgeToRemove) => e.id)

if (safeEdgeIds.length === 0) {
logger.info('All edges are connected to protected blocks, skipping removal')
logger.info('All edges target protected blocks, skipping removal')
return
}

Expand Down Expand Up @@ -1569,13 +1563,13 @@ async function handleEdgesOperationTx(
return false
}

// Filter edges - only add edges where neither block is protected
// Filter edges - only add edges where target block is not protected
const safeEdges = (edges as Array<Record<string, unknown>>).filter(
(e) => !isBlockProtected(e.source as string) && !isBlockProtected(e.target as string)
(e) => !isBlockProtected(e.target as string)
)

if (safeEdges.length === 0) {
logger.info('All edges connect to protected blocks, skipping add')
logger.info('All edges target protected blocks, skipping add')
return
}

Expand Down