fix(adapter): throw helpful error for primitive arrays#1720
Open
Azarcodex wants to merge 1 commit intotypicode:mainfrom
Open
fix(adapter): throw helpful error for primitive arrays#1720Azarcodex wants to merge 1 commit intotypicode:mainfrom
Azarcodex wants to merge 1 commit intotypicode:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1709
This PR improves the error message when json-server encounters arrays containing primitive values.
Previously, the server threw a low-level JavaScript error:
TypeError: Cannot create property 'id' on string 'role-1'
Now the server provides a clearer message explaining that arrays should contain objects so IDs can be generated.
Example valid format:
{ "roles": [{ "id": 1, "name": "role-1" }] }
This improves developer experience by making the issue easier to understand and debug.