Skip to content

Fix arrow tests#35346

Merged
dahbka-lis merged 1 commit intoydb-platform:mainfrom
dahbka-lis:arrow-query-service/empty-result-fixes
Mar 3, 2026
Merged

Fix arrow tests#35346
dahbka-lis merged 1 commit intoydb-platform:mainfrom
dahbka-lis:arrow-query-service/empty-result-fixes

Conversation

@dahbka-lis
Copy link
Member

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Copilot AI review requested due to automatic review settings March 3, 2026 11:17
@dahbka-lis dahbka-lis requested a review from a team as a code owner March 3, 2026 11:17
@dahbka-lis dahbka-lis enabled auto-merge (squash) March 3, 2026 11:17
@ydbot
Copy link
Collaborator

ydbot commented Mar 3, 2026

Run Extra Tests

Run additional tests for this PR. You can customize:

  • Test Size: small, medium, large (default: all)
  • Test Targets: any directory path (default: ydb/)
  • Sanitizers: ASAN, MSAN, TSAN
  • Coredumps: enable for debugging (default: off)
  • Additional args: custom ya make arguments

▶  Run tests

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

🟢 2026-03-03 11:18:09 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

2026-03-03 11:19:27 UTC Pre-commit check linux-x86_64-release-asan for 52aab04 has started.
2026-03-03 11:19:31 UTC Artifacts will be uploaded here
2026-03-03 11:20:52 UTC ya make is running...
🟢 2026-03-03 11:48:43 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70 70 0 0 0 0

🟢 2026-03-03 11:48:47 UTC Build successful.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts Arrow-format unit tests in kqp_result_set_formats_ut.cpp to stop failing when a deserialized Arrow RecordBatch contains 0 rows.

Changes:

  • Removed assertions requiring RecordBatch::num_rows() > 0 in several Arrow streaming/schema-inclusion tests.
  • Removed an assertion requiring non-empty row count in the Arrow compression comparison helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

2026-03-03 11:27:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for 52aab04 has started.
2026-03-03 11:27:37 UTC Artifacts will be uploaded here
2026-03-03 11:29:56 UTC ya make is running...
🟢 2026-03-03 11:41:32 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70 70 0 0 0 0

🟢 2026-03-03 11:41:35 UTC Build successful.

@dahbka-lis dahbka-lis merged commit 410b782 into ydb-platform:main Mar 3, 2026
16 checks passed
@ydbot
Copy link
Collaborator

ydbot commented Mar 3, 2026

Backport

To backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.

Branch Run
stable-25-4, stable-25-4-1, stable-26-1, stable-26-1-1 ▶  Backport
stable-26-1, stable-26-1-1 ▶  Backport
stable-26-1 ▶  Backport

▶  Backport manual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants