direct: model_serving: ignore budget_policy_id, rate_limits at plan level#4638
Merged
direct: model_serving: ignore budget_policy_id, rate_limits at plan level#4638
Conversation
Previously changing these fields would result in planned 'update' but DoUpdate is actually no-op for these. Now, this will be skipped at plan level with appropriate reason.
84b80d4 to
91794b8
Compare
andrewnester
reviewed
Mar 3, 2026
andrewnester
reviewed
Mar 3, 2026
| # Routes have custom SuppressDiff (lines 387-388) | ||
| - field: config.traffic_config | ||
| reason: managed | ||
| - field: budget_policy_id |
Contributor
There was a problem hiding this comment.
Maybe we should do the recreate in this case?
Contributor
Author
There was a problem hiding this comment.
Not sure, what if it changes by some server side policy? We can enter recreate loop (Unless we recreate for local changes only).
Not sure, if it's worth over thinking without clear user case in mind. The goal here is just move what happens inside DoUpdate() to plan level, for visibility. Behaviour unchanged.
Collaborator
|
Commit: 8493568
31 interesting tests: 9 FAIL, 7 KNOWN, 7 SKIP, 5 BUG, 3 flaky
Top 20 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Mar 3, 2026
Collaborator
|
Commit: b634235
59 interesting tests: 30 FAIL, 14 RECOVERED, 8 KNOWN, 5 flaky, 1 SKIP, 1 BUG
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Previously changing these fields would result in planned 'update' but DoUpdate is actually no-op for these, see
cli/bundle/direct/dresources/model_serving_endpoint.go
Line 288 in 10d976b
Now, this will be skipped at plan level with appropriate reason.
Tests
No new tests, this a config-only change.