Skip to content

direct: model_serving: ignore budget_policy_id, rate_limits at plan level #4638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denik merged 5 commits into from
Mar 4, 2026
Merged

direct: model_serving: ignore budget_policy_id, rate_limits at plan level #4638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4cba8d3
direct: model_serving_e: ignore fields we cannot update
denik Mar 3, 2026
68893fa
update NEXT_CHANGELOG
denik Mar 3, 2026
91794b8
update resources README
denik Mar 3, 2026
bf2b291
rm name and description
denik Mar 3, 2026
8493568
update
denik Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

### Bundles
* Validate that either source_code_path or git_source is set for apps ([#4632](https://github.com/databricks/cli/pull/4632))?target=https://github.com
* direct: model_serving_endpoints: ignore budget_policy_id, rate_limits changes in the plan. Previously they were ignored as well but action as "update". ([#4638](https://github.com/databricks/cli/pull/4638))?target=https://github.com

### Dependency updates

Expand Down
1 change: 1 addition & 0 deletions bundle/direct/dresources/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
- The logic what kind of update it is should be in FieldTriggers / ClassifyChange methods. The methods performing update should not have logic in them on what method to call.
- Create/Update/Delete methods should not need to read any state. (We can implement support for passing remoteState we already to these methods if such need arises though).
- Prefer “with refresh” variants of methods if resource API supports that. That avoids explicit DoRead() call.
- For update with complex logic, ensure that DoUpdate() does not result in no-op. If certain fields could not be updated, they should be excluded at plan level in resources.yml.

Nice to have
- Add link to corresponding API documentation before each method.
Expand Down
10 changes: 10 additions & 0 deletions bundle/direct/dresources/resources.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,16 @@ resources:
# Routes have custom SuppressDiff (lines 387-388)
- field: config.traffic_config
reason: managed
- field: budget_policy_id
Copy link
Contributor

@andrewnester andrewnester Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should do the recreate in this case?

Copy link
Contributor Author

@denik denik Mar 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, what if it changes by some server side policy? We can enter recreate loop (Unless we recreate for local changes only).

Not sure, if it's worth over thinking without clear user case in mind. The goal here is just move what happens inside DoUpdate() to plan level, for visibility. Behaviour unchanged.

reason: no_update_api
# There is PublicPreview endpoints but we're not using it https://docs.databricks.com/api/workspace/servingendpoints/put
- field: rate_limits
reason: not_implemented
ignore_local_changes:
- field: budget_policy_id
reason: no_update_api
- field: rate_limits
reason: not_implemented
backend_defaults:
# https://github.com/databricks/terraform-provider-databricks/blob/4eba541abe1a9f50993ea7b9dd83874207e224a1/serving/resource_model_serving.go#L383?target=https://github.com
# common.CustomizeSchemaPath(m, "config", "served_entities", "name").SetComputed()
Expand Down